Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: update generic workflow #137

Merged
merged 1 commit into from
Feb 8, 2024
Merged

readme: update generic workflow #137

merged 1 commit into from
Feb 8, 2024

Conversation

katexochen
Copy link
Member

We still need to think how the user should do port-forwarding of the coordinator. The part of deploying the port-forwarder pod is currently missing.

malt3
malt3 reviewed Feb 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
burgerdev
burgerdev approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

Yes, I intentionally left the port-forwarder out, in the hopes that this would be supported upstream, eventually.

@katexochen katexochen requested a review from malt3 February 8, 2024 12:19
@katexochen katexochen merged commit 6cb3f63 into main Feb 8, 2024
5 checks passed
@katexochen katexochen deleted the p/readme branch February 8, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malt3 malt3 malt3 approved these changes

@burgerdev burgerdev burgerdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katexochen @malt3 @burgerdev